[AI SDK] Surface billing setup errors and handle default AOAI policy for self managed resources #6377
Conversation
…for self managed resources
| AzureOpenAIPolicy := AOAIChatCompletionParams.GetAOAIPolicyParams().GetAOAIPolicy(); | ||
| AOAIPolicyParams := AOAIChatCompletionParams.GetAOAIPolicyParams(); | ||
| AzureOpenAIPolicy := (ChatCompletionsAOAIAuthorization.GetResourceUtilization() = Enum::"AOAI Resource Utilization"::"Self-Managed") and AOAIPolicyParams.IsDefaultPolicy() | ||
| ? '' // The default value is generally not compatible with self managed resources, yet we allow them to specify their own policy and must honor that. |
There was a problem hiding this comment.
Would be good to confirm that a blank policy (by default) will still apply some level of policy control on the prompt, or at the very least, the safety metaprompt is still sufficient in such cases (FYI @darjoo )
There was a problem hiding this comment.
As discussed, the changes done previously by Dishant aimed at exposing the AOAI policies for managed resources mainly. We also added the ability to specify custom policies for self managed resources, but that's dependent on the partner's deployment and the configured policies. This change just avoids setting the managed resource default policy onto a self-manage resource. If the partner sets a policy with the SDK, we include it in the request, if they don't set one we don't include it (which is the same as before). No changes in that regard.
Summary
Issue 1:
We don't surface billing setup issues because an Error is raised within the try function and the operation result is never sent on the response codeunit passed by var. So the error message is never surfaced. Changing the SendRequest to return the error first.
Issue 2:
AOAI policies would default to ConveservativeWithXpia which generally does not exist for self managed resources since that's something dedicated in our copilot service. Changing the SendChatCompletionRequest logic to not pass any XPIA policy for self managed resources if the policy are still the default one.
Work Item(s)
Fixes AB#620032, AB#615189