prow: add presubmit job for node-readiness-controller #36261

Hii-Himanshu · 2026-01-19T07:48:38Z

This PR adds a presubmit Prow job for the node-readiness-controller repository.

k8s-ci-robot · 2026-01-19T07:48:48Z

Welcome @Hii-Himanshu!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2026-01-19T07:48:49Z

Hi @Hii-Himanshu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Hii-Himanshu · 2026-01-19T07:57:34Z

@Priyankasaggu11929 I’ve opened the PR against the kubernetes/test-infra repo as discussed. Happy to iterate based on feedback.

Priyankasaggu11929 · 2026-01-19T10:37:00Z

config/jobs/kubernetes-sigs/node-readiness-controller/OWNERS

+approvers:
+
+reviewers:
+


@Hii-Himanshu, please copy the OWNERS similar to the node-readiness-controller repo here under both approvers and reviewers for now.

Priyankasaggu11929 · 2026-01-19T10:38:58Z

config/jobs/kubernetes-sigs/node-readiness-controller/node-readiness-controller-presubmits.yaml

+  kubernetes-sigs/node-readiness-controller:
+  - name: pull-org-verify-all
+    always_run: true
+    decorate: true
+    spec:
+      containers:
+      - image:
+        command:
+         - make
+        args:
+         - verify


@Hii-Himanshu, please add all fields to the job definition similar to what i provided in the reference job link I provided you.

I will review it again after. Thank you!

k8s-ci-robot · 2026-01-19T11:58:14Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Hii-Himanshu
Once this PR has been reviewed and has the lgtm label, please ask for approval from priyankasaggu11929. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

config/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Priyankasaggu11929 · 2026-01-28T07:26:21Z

/ok-to-test

Priyankasaggu11929

@Hii-Himanshu, I have left a few more comments.

With that, I think we should be ok to merge the PR and test it.

Priyankasaggu11929 · 2026-01-28T07:33:21Z

config/jobs/kubernetes-sigs/node-readiness-controller/node-readiness-controller-presubmits.yaml

@@ -0,0 +1,26 @@
+presubmits:
+  kubernetes-sigs/node-readiness-controller:
+  - name: pull-org-verify-all


Suggested change

- name: pull-org-verify-all

- name: pull-node-readiness-controller-verify-all

let's update the name of the job to ^

will help fix the failing unit test job - https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/test-infra/36261/pull-test-infra-unit-test/2016412534931722240

could not apply prowjob annotations: test group "pull-org-verify-all" already exists FAIL k8s.io/test-infra/config/tests/testgrids 55.520s

Priyankasaggu11929 · 2026-01-28T07:38:26Z

config/jobs/kubernetes-sigs/node-readiness-controller/node-readiness-controller-presubmits.yaml

+      preset-service-account: "true"
+    spec:
+      containers:
+      - image: public.ecr.aws/docker/library/golang:1.22.4


Suggested change

- image: public.ecr.aws/docker/library/golang:1.22.4

- image: us-central1-docker.pkg.dev/k8s-staging-test-infra/images/kubekins-e2e:v20260127-c1affcc8de-master

Let's change the container image ^

Priyankasaggu11929 · 2026-01-28T07:39:05Z

config/jobs/kubernetes-sigs/node-readiness-controller/node-readiness-controller-presubmits.yaml

+    labels:
+      preset-service-account: "true"


Suggested change

labels:

preset-service-account: "true"

Let's remove this preset, I don't think we need this for now.

Priyankasaggu11929 · 2026-01-28T07:42:04Z

config/jobs/kubernetes-sigs/node-readiness-controller/node-readiness-controller-presubmits.yaml

+    annotations:
+      testgrid-num-columns-recent: '30'
+      testgrid-create-test-group: 'true'
+


Suggested change

Drop the trailing empty line here.

Will help fix the failing lint job - https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/test-infra/36261/pull-test-infra-verify-lint/2016412535032385536

config/jobs/kubernetes-sigs/node-readiness-controller/node-readiness-controller-presubmits.yaml 26:1 error too many blank lines (1 > 0) (empty-lines)

Priyankasaggu11929 · 2026-01-29T08:12:29Z

Looking at the failing job logs. I think we need to create a new Testgrid dashboard.
ref: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/test-infra/36261/pull-test-infra-unit-test/2016571053500796928

could not write config: 1 error occurred:
	* configuration error for (TestGroup) pull-node-readiness-controller-verify-all: Each Test Group must be referenced by at least 1 Dashboard Tab.

@Hii-Himanshu, could you create one under this file - config/testgrids/kubernetes/sig-node/config.yaml

Call the dashboard - sig-node-node-readiness-controller

Use this commit for example reference - 4e23341

Priyankasaggu11929 · 2026-01-29T08:16:31Z

config/jobs/kubernetes-sigs/node-readiness-controller/node-readiness-controller-presubmits.yaml

+          requests:
+            cpu: 2
+            memory: 4Gi
+    annotations:


once you have created the new testgrid dashboard following #36261 (comment)

Add the following annotation to use the new testgrid dashboard

Suggested change

annotations:

annotations:

testgrid-dashboards: sig-node-node-readiness-controller

Priyankasaggu11929 · 2026-01-29T08:18:47Z

I'm not sure what is failing the yaml lint, but can you please test it locally once if the yaml file is properly linted.

k8s-ci-robot · 2026-01-29T13:17:11Z

@Hii-Himanshu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-test-infra-unit-test	`b004c0f`	link	true	`/test pull-test-infra-unit-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 19, 2026

k8s-ci-robot requested review from dims and wojtek-t January 19, 2026 07:48

k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 19, 2026

Priyankasaggu11929 requested changes Jan 19, 2026

View reviewed changes

k8s-ci-robot assigned Priyankasaggu11929 Jan 19, 2026

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2026

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2026

Priyankasaggu11929 requested changes Jan 28, 2026

View reviewed changes

Priyankasaggu11929 reviewed Jan 29, 2026

View reviewed changes

Hii-Himanshu added 4 commits January 29, 2026 18:41

prow: add presubmit job for node-readiness-controller

b48d54a

chore: update OWNERS and presubmit job config

470afc4

updated presubmits.yaml

c91098f

fix: yamllint issues in presubmit config

b004c0f

Hii-Himanshu force-pushed the prow-node-readiness-controller-presubmit branch from f8a69c3 to b004c0f Compare January 29, 2026 13:11

k8s-ci-robot added the area/testgrid label Jan 29, 2026

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 29, 2026

github-project-automation bot added this to SIG Node CI/Test Board Jan 29, 2026

github-project-automation bot moved this from Triage to PRs Waiting on Author in SIG Node CI/Test Board Jan 29, 2026

github-project-automation bot moved this to Triage in SIG Node CI/Test Board Jan 29, 2026

	- name: pull-org-verify-all
	- name: pull-node-readiness-controller-verify-all

	- image: public.ecr.aws/docker/library/golang:1.22.4
	- image: us-central1-docker.pkg.dev/k8s-staging-test-infra/images/kubekins-e2e:v20260127-c1affcc8de-master

	annotations:
	annotations:
	testgrid-dashboards: sig-node-node-readiness-controller

		approvers:

		reviewers:

prow: add presubmit job for node-readiness-controller #36261

Are you sure you want to change the base?

prow: add presubmit job for node-readiness-controller #36261

Conversation

Hii-Himanshu commented Jan 19, 2026

Uh oh!

k8s-ci-robot commented Jan 19, 2026

Uh oh!

k8s-ci-robot commented Jan 19, 2026

Uh oh!

Hii-Himanshu commented Jan 19, 2026

Uh oh!

Priyankasaggu11929 Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Priyankasaggu11929 Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jan 19, 2026

Uh oh!

Priyankasaggu11929 commented Jan 28, 2026

Uh oh!

Priyankasaggu11929 left a comment

Choose a reason for hiding this comment

Uh oh!

Priyankasaggu11929 Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Priyankasaggu11929 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Priyankasaggu11929 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Priyankasaggu11929 Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Priyankasaggu11929 commented Jan 29, 2026

Uh oh!

Priyankasaggu11929 Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Priyankasaggu11929 commented Jan 29, 2026

Uh oh!

k8s-ci-robot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Priyankasaggu11929 Jan 28, 2026 •

edited

Loading

k8s-ci-robot commented Jan 29, 2026 •

edited

Loading