HDFS-17878. Reduce frequency of getDatanodeListForReport calls for metrics #8220
+132
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
getDatanodeListForReportis called by a lot of metrics method while holding synchronized lock, interfering with more critical ops like datanodeReport while not having critical data (metrics). Best to reduce the frequency of calls to this method. This patch added a configurable cache that is force-wiped when there is a change in DNs, else expires using the configured expiration period.How was this patch tested?
Product cluster + local UT benchmark