Skip to content

Conversation

@panda2742
Copy link

Hello, I wanted to use this workflow with a Japanese locale, but it seemed nothing was done for that. So I decided to contribute by making the Japanese translation (using the ja_JP locale flag).
Nothing else has been changed.
Tell me if you find some errors.

@ok-coder1 ok-coder1 added the translation Issues/PRs related to translation label Jun 3, 2025
@daoch4n
Copy link

daoch4n commented Jun 8, 2025

Thank you! I've built your fork updated docker image here, Japanese translation works nicely by setting LOCALE: "ja_JP"

Copy link
Owner

@anmol098 anmol098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Code Review by Dume.ai, on behalf of @anmol098

Hello, this pull request has been reviewed by Dume.ai, the AI executive assistant to @anmol098.

Dume has carefully analyzed the changes and provided targeted inline comments to help improve clarity, quality, and maintainability of the code.

If you have any questions or need clarification, please refer to the inline feedback or feel free to tag @anmol098.

Review performed on 2025-06-09T04:32:52.289Z

Powered by Dume.ai – Your AI executive assistant for engineering workflows.

Copy link
Author

@panda2742 panda2742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those changes seem correct with the previous work

@panda2742
Copy link
Author

Isn't a good idea to review this PR and to merge the new feature then?

@github-actions github-actions bot added the python Pull requests that update Python code label Jun 27, 2025
@ok-coder1 ok-coder1 removed the python Pull requests that update Python code label Jun 27, 2025
ok-coder1
ok-coder1 previously approved these changes Jun 27, 2025
Copy link
Collaborator

@ok-coder1 ok-coder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! TYSM!

@DataBoySu
Copy link
Collaborator

The logs have been deleted so no clue why the CI test is failing, its not like anything else is being touched.
Only translation.json addition.

Copy link
Collaborator

@DataBoySu DataBoySu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a native speaker but multiple translation tools flagged the json.
Here are some things I noticed.
"Contributions": You used 寄付 (Kifu), which means "monetary donation."
"Projects": You used 企画 (Kikaku), which means "a plan" or "proposal."
"Timeline": You used 年代記 (Nendaiki), which means "Chronicle" or "Annals"
"Early Bird": アーリーの is not a natural way to describe a person in Japanese.

Despite this, we welcome your contribution, if inconsistencies are, in future, pointed by another user, we can update it later on.

@github-actions github-actions bot added the python Pull requests that update Python code label Jan 2, 2026
@ok-coder1 ok-coder1 removed the python Pull requests that update Python code label Jan 2, 2026
Copy link
Collaborator

@DataBoySu DataBoySu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets keep it ja, not ja_JP for consistency across repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation Issues/PRs related to translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants