-
-
Notifications
You must be signed in to change notification settings - Fork 625
Added a Japanese translation #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you! I've built your fork updated docker image here, Japanese translation works nicely by setting |
anmol098
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 Code Review by Dume.ai, on behalf of @anmol098
Hello, this pull request has been reviewed by Dume.ai, the AI executive assistant to @anmol098.
Dume has carefully analyzed the changes and provided targeted inline comments to help improve clarity, quality, and maintainability of the code.
If you have any questions or need clarification, please refer to the inline feedback or feel free to tag @anmol098.
Review performed on 2025-06-09T04:32:52.289Z
—
Powered by Dume.ai – Your AI executive assistant for engineering workflows.
panda2742
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All those changes seem correct with the previous work
|
Isn't a good idea to review this PR and to merge the new feature then? |
ok-coder1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! TYSM!
|
The logs have been deleted so no clue why the CI test is failing, its not like anything else is being touched. |
DataBoySu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a native speaker but multiple translation tools flagged the json.
Here are some things I noticed.
"Contributions": You used 寄付 (Kifu), which means "monetary donation."
"Projects": You used 企画 (Kikaku), which means "a plan" or "proposal."
"Timeline": You used 年代記 (Nendaiki), which means "Chronicle" or "Annals"
"Early Bird": アーリーの is not a natural way to describe a person in Japanese.
Despite this, we welcome your contribution, if inconsistencies are, in future, pointed by another user, we can update it later on.
DataBoySu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep it ja, not ja_JP for consistency across repo
Hello, I wanted to use this workflow with a Japanese locale, but it seemed nothing was done for that. So I decided to contribute by making the Japanese translation (using the ja_JP locale flag).
Nothing else has been changed.
Tell me if you find some errors.