fix: multiple updates including code fixes, test improvements, depend… #14129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency adjustments, and docs tweaks
|
|
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Collaborator
|
Please create issues for each changes. Don't merge in one PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several fixes and enhancements to improve code quality, test reliability, and documentation in Nacos. I focused on resolving errors and inconsistencies I encountered while exploring the codebase. All changes have been tested locally where applicable.
Key Changes:
Documentation:
Updated CODE_OF_CONDUCT.md to fix typos and clarify guidelines for better community engagement.
Address Module:
Fixed errors in AddressServerClusterControllerTest.java (e.g., improved test assertions and handled edge cases).
Config Module:
Corrected issues in EmbeddedConfigDumpApplyHook.java (e.g., refined dump logic to prevent potential data loss).
Istio Module:
Updated dependencies in istio/pom.xml.
Fixed model-related errors in IstioEndpoint.java (e.g., aligned with latest Istio specs).
Naming Module:
Updated dependencies in naming/pom.xml.
Resolved utility function errors in DistroUtils.java (e.g., improved distribution handling for better performance).
Auth Plugin:
Updated dependencies in nacos-default-auth-plugin/pom.xml.
Fixed authentication logic in LdapAuthenticationProvider.java (e.g., enhanced LDAP connection stability).
Improved test coverage and fixed failures in:
SafeBcryptPasswordEncoderTest.java
LdapAuthenticationProviderTest.java
PasswordEncoderUtilTest.java
Root Project:
Updated top-level dependencies in pom.xml to resolve version conflicts and security vulnerabilities.
Additional Files:
Added deps.txt as a reference for dependency notes (optional; can be removed if not needed).
Motivation:
These fixes address common errors like compilation issues, test flakiness, and outdated docs that I ran into while setting up and running Nacos locally. They should make the project more robust for new contributors.
Testing:
Built and ran the project with Maven: mvn clean install.
Verified tests pass in affected modules (e.g., mvn test -pl address,config,naming,plugin-default-impl).
No new dependencies introduced beyond updates.
Related Issues:
Fixes # [add issue numbers here if applicable, e.g., #1234 for a specific bug]
Please review and let me know if any adjustments are needed. Happy to iterate!