A hopefully working C++17 build that automatically includes the C++17 build. #2564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
This reverts commit c3a35d9.
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
This reverts commit c3bdaa4.
This reverts commit aa611ca.
This reverts commit b2e4fa3.
This reverts commit a5b66f8.
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
# Conflicts: # test/SparqlExpressionTest.cpp
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
# Conflicts: # src/util/Views.h # test/ViewsTest.cpp
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
# Conflicts: # src/backports/iterator.h # src/util/Views.h # test/ViewsTest.cpp # test/backports/BackportIteratorTest.cpp
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
…rg#2316) * Migrate coroutines in IndexScan * Reduce code duplication * Make changes clean * Refactor IndexScan::getLazyScan to apply column subsets * Simplify chunkedIndexScan * Restore unintentional change * Use LoopCOntrol whenever possible * Remove unnecessary function * Restore materializedIndexScan function * Implement breakWithYieldAll to LoopControl * Refactor createPrefilteredIndexScanSide * Fix some sonarqube issues * Clean up remove unnecessary comments * Update details in lazy iterations * Incorporate changes based on review comments * Fix sonarqube issues * Apply details aware transform * Implement wrapper for InputRangeFromGet * Add style comment in test Co-authored-by: Johannes Kalmbach <joka921@users.noreply.github.com> * Use Range alias Co-authored-by: Johannes Kalmbach <joka921@users.noreply.github.com> * Incorporate commit suggestions * Simplify getLazyScan function * Working on simplifications. Not yet working. Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com> * Fix the tests, It is working now. Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com> * Provide template parameter for SetDetails * Adre Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com> * Also make sonarcloud happy. Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com> --------- Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com> Co-authored-by: Johannes Kalmbach <joka921@users.noreply.github.com> Co-authored-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
…txihimprovements.s with sworkxiAdd another missing typename.ing driFix the merge for the range include. path filling.ape points Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
# Conflicts: # src/engine/CartesianProductJoin.cpp # src/engine/Engine.cpp # src/engine/IndexScan.cpp # src/engine/Join.cpp # src/engine/Operation.cpp # src/engine/ParsedRequestBuilder.cpp # src/engine/RuntimeInformation.cpp # src/engine/SortPerformanceEstimator.cpp # src/engine/sparqlExpressions/AggregateExpression.cpp # src/engine/sparqlExpressions/AggregateExpression.h # src/engine/sparqlExpressions/DateExpressions.cpp # src/engine/sparqlExpressions/NaryExpressionImpl.h # src/engine/sparqlExpressions/RegexExpression.cpp # src/engine/sparqlExpressions/SampleExpression.h # src/engine/sparqlExpressions/SparqlExpressionTypes.h # src/engine/sparqlExpressions/StringExpressions.cpp # src/global/ValueId.h # src/index/IndexImpl.cpp # src/index/LocalVocabEntry.h # src/parser/CMakeLists.txt # src/rdfTypes/RdfEscaping.h # src/util/ConstexprUtils.h # src/util/GeneratorConverter.h # src/util/GeoSparqlHelpers.cpp
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
# Conflicts: # src/engine/CallFixedSize.h # src/engine/GroupBy.cpp # src/engine/GroupBy.h # src/engine/GroupByImpl.cpp # src/engine/GroupByImpl.h # src/index/CompressedRelation.cpp # src/index/DeltaTriples.cpp # src/index/IndexImpl.Text.cpp # src/index/LocatedTriples.cpp # test/CallFixedSizeTest.cpp # test/ViewsTest.cpp # test/engine/ValuesForTesting.h
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
# Conflicts: # src/engine/AddCombinedRowToTable.h # src/index/IndexBuilderTypes.h # src/parser/Tokenizer.h # src/parser/TokenizerCtre.h # src/util/JoinAlgorithms/JoinAlgorithms.h
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
# Conflicts: # src/engine/sparqlExpressions/RelationalExpressions.cpp # src/engine/sparqlExpressions/SparqlExpressionGenerators.h # test/SparqlExpressionGeneratorsTest.cpp
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
…ays about this. Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.