fix(spring): Add Nullable import for array-type models (#22788)

[spider-yamet]

Description

Fix missing Nullable import in array-type models generated by the Spring codegen. This resolves a compilation error where models using @Nullable annotation in toIndentedString() method were missing the required import.

Fixes #22788

Problem

Array-type models (schemas with type: array without explicit properties) were generated without the org.springframework.lang.Nullable import, causing compilation failure:

Root Cause

The Nullable import was being added in postProcessModelProperty(), but this method is only called for models with properties. Array-type models have no properties, so the hook was never invoked.

Solution

Moved the Nullable import logic from postProcessModelProperty() to fromModel(), which is called for all models regardless of whether they have properties.

Changes

• modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java
  • Removed Nullable import logic from postProcessModelProperty()
  • Added Nullable import logic to fromModel()
• modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
  • Added shouldAddNullableImportForArrayTypeModels() test case

PR checklist

• Added test case to cover the change
• Documented fix in code comments
• Verified fix by generating code and confirming successful compilation

---

Summary by cubic

Fixes missing org.springframework.lang.Nullable import in Spring-generated array-type models, preventing compilation errors when @nullable is used in toIndentedString(). The import is now added for all models.

• Bug Fixes
  • Moved import logic to fromModel and extracted helpers, ensuring array-type models receive the Nullable import.
  • Added test to verify the import exists for array-type models (AnimalFarm.java) and standard models (Pet.java).

^{Written for commit 554fc76. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 2 files

[wing328]

thanks for the PR

cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

[wing328]

thanks for the pr

please follow step 3 to update the samples

[spider-yamet]

Could you please check again, @wing328? I updated by following steps.

Regards

[spider-yamet]

@wing328 could you please approve ci pipelines for my update?

Regards

[cubic-dev-ai]

3 issues found across 63 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="samples/client/petstore/php-nextgen/OpenAPIClient-php/phpunit.xml.dist">

<violation number="1" location="samples/client/petstore/php-nextgen/OpenAPIClient-php/phpunit.xml.dist:5">
P2: Coverage include directories now contain literal backslashes (`./src\/Api`, `./src\/Model`), which changes the filesystem path and can cause PHPUnit to skip these directories for coverage collection.</violation>
</file>

<file name="samples/client/echo_api/php-nextgen/phpunit.xml.dist">

<violation number="1" location="samples/client/echo_api/php-nextgen/phpunit.xml.dist:5">
P2: The added backslash becomes part of the path in XML, so PHPUnit will look for a non-existent `src\Api` directory and skip coverage for that folder.</violation>
</file>

<file name="samples/client/echo_api/php-nextgen-streaming/phpunit.xml.dist">

<violation number="1" location="samples/client/echo_api/php-nextgen-streaming/phpunit.xml.dist:5">
P2: Coverage include paths now contain a literal backslash (`./src\/Api`, `./src\/Model`), which makes them refer to different/nonexistent directories and can cause PHPUnit to skip source files for coverage.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}