Declare internal source attributes in consuming projects

[jnm2]

Alternative to the approach taken in #130

I tested the nupkg and was able to use the attributes in a new console project just by referencing the package. When I added <IncludeOwnershipAttributes>false</IncludeOwnershipAttributes> to the csproj, the attributes were no longer declared.

Resulting package file structure:

 IDisposableAnalyzers.3.3.4
 │   IDisposableAnalyzers.nuspec
 │
 ├───analyzers
 │   └───dotnet
 │       └───cs
 │               Gu.Roslyn.Extensions.dll
 │               IDisposableAnalyzers.dll
 │
+├───build
+│       IDisposableAnalyzers.targets
+│       OwnershipAttributes.cs
 │
 └───tools
         install.ps1
         uninstall.ps1

[JohanLarsson]

This looks perfect!
Gonna wait for a bit with merging, trying to close some bug issues first.

[jnm2]

@JohanLarsson We need to test this in a WPF project because I think it will suffer from the same issue as tunnelvisionlabs/ReferenceAssemblyAnnotator#81.

[jeremyVignelles]

Sorry, I didn't see that you implemented it :)

I'm ok with the set, with a few remarks

[jeremyVignelles]

For your remark about WPF, I don't know if that can be an issue. I'd think that the way both package work are quite different.
In our case we add a source file into the project directly, we're not adding things to the build pipeline dynamically (I don't know what ReferenceAssemblyAnnotator does, but from the name, it seems that it does specific things, right?)

[jnm2]

For your remark about WPF, I don't know if that can be an issue. I'd think that the way both package work are quite different.
In our case we add a source file into the project directly, we're not adding things to the build pipeline dynamically (I don't know what ReferenceAssemblyAnnotator does, but from the name, it seems that it does specific things, right?)

The problem with WPF is only related to including a source file into the project. I.e. it's related to added <Compile> items, not to <Reference> items. WPF creates a temp copy of the csproj using the file system and only carries certain things over into it. In the mix, our added <Compile> item is never provided a way to show up in this temp project.

Specifically, the problem is that the .targets file is not included in the WPF temp project and so <Compile Include="$(OwnershipAttributesPath)" Visible="false" /> never happens for the temp project.

[jnm2]

Good news, I found an easy fix to work around the WPF problem. https://github.com/tunnelvisionlabs/ReferenceAssemblyAnnotator/pull/82/files#diff-e981fad1d30fcb8e912da7c14997e6caR20

[jnm2]

Closing since this PR was mainly a demonstration. If you'd like to take this approach in the future, this can serve as a reference.