enter: don't filter environment variables with special characters #1858
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
|
@cshuaimin it looks like the formatter is failing, could you fix it? ❤️ |
cshuaimin
force-pushed
the
push-wtxyqquwxuot
branch
from
685eb48 to
5fbe307
Compare
Author
|
Hi @dottorblaster I fixed formatting. |
Previously when passing environment variables from the host to the container, the script filtered out any variables that contained special characters. This could lead to important environment variables being omitted when entering the container. In this commit, I modified it to only pass the names of the environment variables to the --env flag, rather than their full key-value pairs, and let container runtime read the values. I also changed printenv to separate lines with null characters to avoid issues with newlines in variable values.
cshuaimin
force-pushed
the
push-wtxyqquwxuot
branch
from
5fbe307 to
6b346e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1842
Docker and Podman support only specifying env names, but seems lilipod doesn't. I'm not sure how to deal with lilipod, should I add an if condition?