Move notification for repository sync

[agjohnson]

I didn't see where we implemented a notification for this until I hit the UI myself. It felt like UX that was misplaced. I noted in #7185 this should be moved.

• Automatically sync github/etc remote repositories thorugh webhook #7185

This notification is only relevant if the user is trying to interact with the list of remote repositories, which happens on the project creation page and the project settings page. We should limit this display to those pages so the user isn't interrupted if the warning is not relevant to the user.

I don't think the notification system has granularity to only display on a project create view though, we only have filtering by model instances. Worst case, a toast notification is better, but overall notifications should be last resort when building UI. These notifications are very far removed from the UI that it is actually affecting.

Long term, this feature should more obviously be native UI in the project create page and project settings page. Context data could drive a simple refreshing warning on both, or just show the existing refreshing UI as in progress.

[agjohnson]

Seems this was added to give GHA SSO users something on their dashboard while we sync.

So, at very least, this notification should not be a notification for users that already have an organization. For normal users, we should pursue proper UI above if we want to surface our async task around repository syncing.

[humitos]

I had problems parsing the description of this issue and I'm still not 100% sure what's the notification you are talking about 😅 . It would help a lot to add a screenshot to make quick references to allow easy parsing, instead of having to read the whole description and clicking on links to other issues.

Don't get me wrong, I appreciate a lot the history/references to other issues, but I'd appreciate also to have quick references for easy parsing as well 👍🏼

[stsewd]

Seems this was added to give GHA SSO users something on their dashboard while we sync.

yes, for those users we need the notification to show when listing projects, as their permissions come from the remote repositories relationships. Also, before doing the sync, we don't know if the user belongs to an organization with VCS SSO, so we can't separate regular users from VCS SSO users.

[agjohnson]

Also, before doing the sync, we don't know if the user belongs to an organization with VCS SSO, so we can't separate regular users from VCS SSO users.

This seems fine still, at least for now. The notification is vague currently -- "we're syncing repositories" -- and so this works for both SSO and non-SSO users at the moment.

Later, we do need to make it clear we're joining the user into organizations though. This is not clear now. "Syncing permissions" doesn't imply "joining my company's organization" to normal users. This is where we might need separate UI for the personas though.

yes, for those users we need the notification to show when listing projects

For users with no projects and no organizations, this notification is fine. This was the reason for the notification, but I think this should be the boundary of this feature.

I don't think we should show this otherwise. The notification sounds destructive and is already confusing users. For non-SSO users it's mostly noise, and even for SSO users I think the cases it covers are edge case and we shouldn't distract all users for these.

Either way, these feel like two separate features we shouldn't be joining. One should be a more prominent UI and one should be a very minor loading indicator.